Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add button for "stage" asset selector #42

Closed
wants to merge 1 commit into from
Closed

Conversation

mfrisbey
Copy link
Collaborator

This PR adds another button to the sidekick for a "stage" asset selector. This is a temporary solution so that we can more safely iterate on the selector.

This button will point to the selector on the rail branch so that we can commit to that branch and see selector changes without needing to commit to main.

The button also uses an application-level client ID, and points to an AEM environment in cloud manager stage.

Test URLs:

@mfrisbey mfrisbey requested a review from tmathern August 17, 2023 19:41
@aem-code-sync
Copy link

aem-code-sync bot commented Aug 17, 2023

Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

@aem-code-sync
Copy link

aem-code-sync bot commented Aug 17, 2023

Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link

@tmathern tmathern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We just did something similar with Brendan!

@mfrisbey
Copy link
Collaborator Author

Closing this PR because the sidekick project advanced options has a checkbox that will force the sidekick to read its config.json properties from local.

@mfrisbey mfrisbey closed this Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants